Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lcd-testing 303030 bug continued #3958

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Fix lcd-testing 303030 bug continued #3958

merged 2 commits into from
Mar 21, 2019

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Mar 21, 2019 •
edited by alexanderbez
Loading

closes #3739

This simple code movement should do the trick, basically, this provides only two blocks for the slash to take place if this bug is to come up again. So this bug may still come up once in a blue blue moon - highly unlikely though. The actual solution is to restructure the lcd so that all the validators are signing.....

CC @alexanderbez

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez self-requested a review March 21, 2019 17:21
@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #3958 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3958      +/-   ##
===========================================
- Coverage    60.44%   60.42%   -0.02%     
===========================================
  Files          196      196              
  Lines        14488    14488              
===========================================
- Hits          8757     8755       -2     
- Misses        5150     5152       +2     
  Partials       581      581

alexanderbez
alexanderbez approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rigelrozanski
Copy link
Contributor Author

going to go ahead and merge this with one approval because it's inconsequential (sew me)

@rigelrozanski rigelrozanski merged commit 9b27901 into develop Mar 21, 2019
@rigelrozanski rigelrozanski deleted the rigel/lcd303030bugpart2 branch March 21, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@alessio alessio Awaiting requested review from alessio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lcd 303030 bug continued
2 participants
@rigelrozanski @alexanderbez